UISACQCOMP-223: ECS - Add reusable custom hooks to fix invalid reference issues related to holding names and locations #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce issues related to holding names and locations
SerhiiNosko
approved these changes
Oct 24, 2024
11 tasks
|
|
||
| const DEFAULT_DATA = []; | ||
|
|
||
| export const useHoldingsAndLocations = ({ |
There was a problem hiding this comment.
The hook's name is too general given that it requires many specific arguments.
|
|
||
| import { useCurrentUserTenants } from '../consortia'; | ||
|
|
||
| export const useReceivingTenantIdsAndLocations = ({ |
There was a problem hiding this comment.
Could you please leave the purpose of this hook in the comments?
lib/utils/getHoldingLocations.js
Outdated
|
|
||
| const DEFAULT_DATA = []; | ||
|
|
||
| export const getHoldingLocations = async ({ |
There was a problem hiding this comment.
Based on the name of this function, I expect to get a list of locations for a specific holding according to certain parameters, not for a list of holdings.
lib/utils/getHoldingLocations.js
Outdated
| }; | ||
| }; | ||
|
|
||
| export const getHoldingLocationsByTenants = async ({ |
|
|
@folio-org/fe-tl-reviewers ^^^ please review |
usavkov-epam
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UISACQCOMP-223: ECS - Add reusable custom hooks to fix invalid reference issues related to holding names and locations to support those tickets UIOR-1330 and UIREC-393
Approach
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.